Fix #5973 on windows by disregarding errors when querying legacy cert path #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
reviewed
Jan 9, 2019
builtin/logical/pki/cert_util.go
Outdated
| return nil, errutil.InternalError{Err: fmt.Sprintf("error fetching certificate %s: %s", serial, err)} | ||
| } | ||
| // Retrieve the old-style path. We disregard errors here because they always manifest on windows, and thus the initial | ||
| // check for a revoked cert fails would return an error when the cert isn't revoked, preventing the happy path from working. |
There was a problem hiding this comment.
Could you wrap your comments at a 80 width?
ncabatoff
force-pushed
the
issue5973-ignore-cert-legacypath-errors
branch
from
3fec1ef to
0681df1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jefferai suggested either disregarding the error here or skipping the legacy query when on windows; I chose to do the former as it seemed a smaller change.