Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save secretData for json on both model and component #5660

Merged
merged 1 commit into from
Oct 31, 2018
Merged

save secretData for json on both model and component #5660

merged 1 commit into from
Oct 31, 2018

Conversation

madalynrose
Copy link
Contributor

No description provided.

@madalynrose madalynrose requested a review from meirish October 31, 2018 22:28
meirish
meirish approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@meirish meirish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@madalynrose madalynrose merged commit bd55a62 into master Oct 31, 2018
@madalynrose madalynrose deleted the json-edit-bugfix branch October 31, 2018 22:37
@meirish meirish mentioned this pull request Nov 1, 2018
Closed
briankassouf pushed a commit that referenced this pull request Nov 9, 2018
@madalynrose
fix bug where json editing doesn't save properly for secrets (#5660)
6f4779e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meirish meirish meirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madalynrose @meirish