UI - kv v2 versions page #5563
UI - kv v2 versions page #5563
Conversation
| .adapterFor('secret-v2-version') | ||
| .v2DeleteOperation(this.store, this.version.id, deleteType); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Most of this was in secret-edit and is now moved to its own component so that we could use it on the show page, and now on the version history page.
|
👍 on the template side and looks good in action. I'll let someone else approve from the JS side though (can we remove the |
|
Oh yep! Not sure why that got added there.... Thanks for checking it out! |
| </div> | ||
| </div> | ||
| <div class="level-left is-flex-1"> | ||
| {{#link-to params=linkParams class="has-text-weight-semibold has-text-black is-display-flex is-flex-1 is-no-underline"}} |
There was a problem hiding this comment.
whew, that's quite the class list. 😉
There was a problem hiding this comment.
😬 Yeah - hoping to move away from this - or at least hide it under the rug with more components
| @tagName="button" | ||
| > | ||
| {{#if useDefaultTrigger}} | ||
| <ICon aria-label="More options" @glyph="more" @size="16" @class="has-text-black auto-width" /> |
There was a problem hiding this comment.
ah, funny. is the component named ICon because ember forces each component to have a dash in the name? 🤣
There was a problem hiding this comment.
Lol exactly - the new angle bracket syntax doesn't have that limitation, but we'll have to convert it everywhere at once.
meirish
force-pushed
the
ui-kv-v2-versions
branch
from
8123363 to
afd8b27
Compare
Version link from the list page:
Version link from the show page:
New Version history page:
