Fix zeroaddress config example #5527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameter expects comma separated string but the example is a list
|
I'd prefer if we didn't merge this and instead just fixed the API |
jefferai
added a commit
that referenced
this pull request
Oct 16, 2018
|
Hey @jefferai, it seems most (if not all) of the parameters take a string, even those suggesting list require a comma-separated string. It sounds like the API fix would mean accepting a list, but this seems out of sorts with the other parameters. Am I misunderstanding your comment? |
briankassouf
pushed a commit
that referenced
this pull request
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter expects comma separated string but the example is a list