Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add default NotBefore duration in PKI #5482

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Re-add default NotBefore duration in PKI #5482

merged 1 commit into from
Oct 10, 2018

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Oct 8, 2018

Fixes #5481

@jefferai jefferai added this to the next-release milestone Oct 8, 2018
chrishoffman
chrishoffman approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@chrishoffman chrishoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to update the docs to say if the value is unset, then it will fall back to the global default of 30s.

@chrishoffman chrishoffman modified the milestones: next-release, 0.12 Oct 9, 2018
@jefferai
Copy link
Member Author

@chrishoffman the docs actually do specify a default of 30s, it's the code that stopped honoring it.

@jefferai jefferai merged commit 1200c98 into master Oct 10, 2018
@jefferai jefferai deleted the issue05481 branch October 10, 2018 13:43
@jefferai jefferai modified the milestones: 0.12, 0.11.4 Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishoffman chrishoffman chrishoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jefferai @chrishoffman