logical/aws: Run Acceptance Tests in Parallel #5383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting an effort to paralleize AWS secret engine acceptance tests. Currently they take over a minute to run, and this parallelizes the two that explicitly call a 10-second sleep, reulting in a 10-second speedup in test time.
Probably not needed, but future-proofing the code
AWS_ACCOUNT_ID environment variable is no longer being used; global mutable state is a recipe for disaster when trying to run things in parallel, and parallelizing the tests exposed a race condition in which they were depending on the AWS_ACCOUNT_ID environment variable to be set before they were run. AWS_DEFAULT_REGION is still left as an environment variable because it is required by AWS SDKs, but its configuration is now protected by a sync.Once to ensure it only ever gets called a single time.
catsby
reviewed
Sep 24, 2018
joelthompson
added a commit
to joelthompson/vault
that referenced
this pull request
Sep 26, 2018
The merge of hashicorp#5383 broke the tests due to some changes in the test style that didn't actually cause a git merge conflict. This updates the tests to the new style.
chrishoffman
pushed a commit
that referenced
this pull request
Oct 2, 2018
* Allow specifying role-default TTLs in AWS secret engine * Add an acceptance test * Add docs for AWS secret role-default TTLs * Rename default_ttl to default_sts_ttl * Return default_ttl as int64 instead of time.Duration * Fix broken tests The merge of #5383 broke the tests due to some changes in the test style that didn't actually cause a git merge conflict. This updates the tests to the new style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acceptance tests on master currently run in about 64 seconds for me; this brings their runtime down to 22 seconds, which is a much more pleasant feedback time. It also exposed a bug in the tests that required them to execute in a certain order to succeed; now they should be much more independent.