Add error logical.ErrUpstreamRateLimited and return 502 from RespondCommonError #5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tyrannosaurus-becks
previously approved these changes
Sep 4, 2018
jefferai
previously approved these changes
Sep 5, 2018
|
Looks good and it doesn't really affect anything so I think can be merged now. |
catsby
dismissed stale reviews from jefferai and tyrannosaurus-becks
via
185cfe8
catsby
force-pushed
the
respond-upstream-throttle
branch
from
adebee5 to
185cfe8
Compare
catsby
force-pushed
the
respond-upstream-throttle
branch
from
185cfe8 to
c5ad933
Compare
jefferai
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error type
ErrUpstreamRateLimitedto the logical package errors and return ahttp. StatusBadGatewayerror inRespondErrorCommonif encountered.