More descriptive errors with specific HTTP return codes #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specify more concrete error cases to make their way back up the stack. Over time there is probably a cleaner way of doing this, but that's looking like a more massive rewrite and this solves some issues in the meantime. Use a CodedError to return a more concrete HTTP return code for operations you want to do so. Returning a regular error leaves the existing behavior in place.
|
@ctennis Looks great, thanks! |
armon
added a commit
that referenced
this pull request
Aug 11, 2015
More descriptive errors with specific HTTP return codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new error class that logical backends can use to specify more concrete error statuses to be returned to the HTTP stack in those cases. For non-changed cases, existing behavior is preserved.
This was inspired by #235 where double mounts caused a 500 error. This is because as you go back down the call chain, it doesn't know how to distinguish errors in client input and operation from backend errors.
This updates this specific case to now return a 409 Conflict instead of a 500 error for this specific case, but other cases can also be tackled as needed. There's at least one other ticket opened for the same type of issue.