Custom extended key usage for PKI #4667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexionescu
commented
May 31, 2018
alexionescu
commented
- Adds ability to have roles that sign certificates with custom EKU OIDs.
- Adds ability to have roles that sign certificates with custom EKU OIDs.
meirish
reviewed
May 31, 2018
ui/app/models/role-pki.js
Outdated
| @@ -55,6 +55,10 @@ export default DS.Model.extend({ | |||
| defaultValue: 'DigitalSignature,KeyAgreement,KeyEncipherment', | |||
| editType: 'stringArray', | |||
| }), | |||
| extKeyUsageOIDs: attr({ | |||
There was a problem hiding this comment.
ext_key_usage_oids will get "camelized" to extKeyUsageOids - so will need to change that here and below.
jefferai
reviewed
May 31, 2018
| @@ -451,6 +457,7 @@ func (b *backend) pathRoleCreate(ctx context.Context, req *logical.Request, data | |||
| UseCSRCommonName: data.Get("use_csr_common_name").(bool), | |||
| UseCSRSANs: data.Get("use_csr_sans").(bool), | |||
| KeyUsage: data.Get("key_usage").([]string), | |||
| ExtKeyUsageOIDs: data.Get("ext_key_usage_oids").([]string), | |||
There was a problem hiding this comment.
Can you add a check on the values similar to the PolicyIdentifiers check below? That way we'll know there won't be an error when generating a cert, instead of silently ignoring it.
jefferai
reviewed
May 31, 2018
| @@ -1045,6 +1057,8 @@ func createCertificate(data *dataBundle) (*certutil.ParsedCertBundle, error) { | |||
|
|
|||
| addKeyUsages(data, certTemplate) | |||
|
|
|||
| addExtKeyUsageOids(data, certTemplate) | |||
There was a problem hiding this comment.
This needs to be in signCertificate too
jefferai
reviewed
May 31, 2018
builtin/logical/pki/path_roles.go
Outdated
| @@ -166,6 +166,12 @@ To remove all key usages from being set, set | |||
| this value to an empty list.`, | |||
| }, | |||
|
|
|||
| "ext_key_usage_oids": &framework.FieldSchema{ | |||
| Type: framework.TypeCommaStringSlice, | |||
| Default: []string{}, | |||
There was a problem hiding this comment.
Don't set an empty default here -- it's done automatically!
jefferai
previously approved these changes
May 31, 2018
|
Also please |
jefferai
changed the title
|
Thank you for reviewing it so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.