Enterprise version detection fix #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisdair
previously approved these changes
May 10, 2018
ui/app/routes/vault/cluster.js
Outdated
| @@ -29,7 +30,10 @@ export default Ember.Route.extend(ModelBoundaryRoute, ClusterRoute, { | |||
|
|
|||
| model(params) { | |||
| const id = this.getClusterId(params); | |||
| return this.get('store').findRecord('cluster', id); | |||
|
|
|||
| return this.get('version').fetchFeatures().then(() => { | |||
There was a problem hiding this comment.
Could move this to a beforeModel hook, to prevent the explicit promise chaining and keep the model hook simple.
There was a problem hiding this comment.
Oh yep, good call - updated in e9721df. Thanks!
meirish
force-pushed
the
enterprise-version-fix
branch
from
58c07ff to
e9721df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug if you were running the HSM build of Enterprise where the UI would parse the version wrong and lock you out of all Enterprise features.
In addition there was a race condition with the replication menu so you'd only see the type of replication you had enabled in the menu and Performance would be an upsell link. Now we fetch features at the cluster route to ensure they're loaded before the application nav renders.
We also fixed a small layout bug in the replication menu.