Disable identity for local mounts #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Apr 20, 2018
| if auth.Alias != nil { | ||
| mEntry := c.router.MatchingMountEntry(req.Path) | ||
|
|
||
| if auth.Alias != nil && mEntry != nil && !mEntry.Local { |
There was a problem hiding this comment.
You're missing the auth/token/renew path earlier on, which can also end up updating memberships.
There was a problem hiding this comment.
I left the renewal flow as it is to allow it to work if the tokens were created before this fix. The thought I had was to only disallow entity attachment for the newly created tokens.
jefferai
reviewed
Apr 20, 2018
| @@ -329,6 +329,10 @@ func (i *IdentityStore) CreateOrFetchEntity(alias *logical.Alias) (*identity.Ent | |||
| return nil, fmt.Errorf("invalid mount accessor %q", alias.MountAccessor) | |||
| } | |||
|
|
|||
| if mountValidationResp.MountLocal { | |||
There was a problem hiding this comment.
Shouldn't this happen later so that existing values are returned?
There was a problem hiding this comment.
It wouldn't matter. This function will not be called for the new tokens.
There was a problem hiding this comment.
OK, I just figured from the name (Create or Fetch) that it could end up creating new entities...which it can... :-)
jefferai
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.