X-Forwarded-For #4380
Merged
X-Forwarded-For #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
reviewed
Apr 17, 2018
command/server/config.go
Outdated
| @@ -761,6 +761,10 @@ func parseListeners(result *Config, list *ast.ObjectList) error { | |||
| "address", | |||
| "cluster_address", | |||
| "endpoint", | |||
| "forwarded_for_authorized_addrs", | |||
| "forwarded_for_hop_skips", | |||
| "forwarded_for_reject_non_authorized", | |||
There was a problem hiding this comment.
Thoughts on non_authorized vs not_authorized? not_authorized can go a little better with not_present.
vishalnayak
reviewed
Apr 17, 2018
helper/parseutil/parseutil.go
Outdated
| for _, addr := range stringAddrs { | ||
| sa, err := sockaddr.NewSockAddr(addr) | ||
| if err != nil { | ||
| return nil, errwrap.Wrapf("error parsing address: {{err}}", err) |
There was a problem hiding this comment.
Do we want to mention the problematic addr in the error statement?
calvn
reviewed
Apr 17, 2018
http/handler.go
Outdated
| if len(headers) == 1 { | ||
| headers = strings.Split(headers[0], ",") | ||
| } | ||
| for i, v := range headers { |
There was a problem hiding this comment.
Is passing multiple X-Forward-For headers that are each comma separated valid [0]? If so, this is only iterating through the first set and not parsing the values correctly.
[0]: -H 'X-Forwarded-For: 203.0.113.100, 203.0.113.101' -H 'X-Forwarded-For: 203.0.113.200, 203.0.113.201'
There was a problem hiding this comment.
It's not an actual standard, so...no idea? I guess I can handle that.
calvn
previously approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs are still todo.
This uses the approach of "specify how many hops back we should be looking" rather than some metric like "is a public IP" in order to validate. Behavior on unauthorized address or missing header can be set to reject or allow (without actually trusting the header).