Remove core restriction in cache and turn it into an active/standby restriction instead #3849
Conversation
restriction instead.
vault/core.go
Outdated
| purgable.Purge(c.activeContext) | ||
| } | ||
| c.physicalCache.Purge(c.activeContext) | ||
| c.physicalCache.SetEnabled(true) |
There was a problem hiding this comment.
I think we want to conditionally enable it based on if we have caching disabled in the config
There was a problem hiding this comment.
Oops yes you're right. I thought about that before and then forgot to do it.
physical/physical.go
Outdated
| // Purgable is an optional interface for backends that support | ||
| // purging of their caches. | ||
| type Purgable interface { | ||
| // An interface for backends that can toggle on or off special functionality |
There was a problem hiding this comment.
Small nit, but it should start with "ToggleablePurgemonster is ..."
physical/inmem/cache_test.go
Outdated
| @@ -63,268 +64,3 @@ func TestCache_Purge(t *testing.T) { | |||
| t.Fatalf("should not have key") | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Should we add test cases for when cache.SetEnabled(false) to make sure operations are not getting/modifying from cached values?
There was a problem hiding this comment.
I can add such a test, good idea.
| backend: b, | ||
| lru: cache, | ||
| locks: locksutil.CreateLocks(), | ||
| logger: logger, |
There was a problem hiding this comment.
enabled seems to be false by default (meaning no cache), is this intentional?
There was a problem hiding this comment.
Ahh, in that case perhaps adding a comment on the need to call SetEnabled before the Cache really starts caching would be helpful.
physical/physical.go
Outdated
| // Purgable is an optional interface for backends that support | ||
| // purging of their caches. | ||
| type Purgable interface { | ||
| // ToggleablePurgemonsteris an interface for backends that can toggle on or off |
There was a problem hiding this comment.
s/ToggleablePurgemonsteris/ToggleablePurgemonster is/
jefferai
dismissed stale reviews from calvn, chrishoffman, and briankassouf
via
ae095fd
No description provided.