Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logical.Initialize() method #3848

Merged
merged 3 commits into from
Jan 26, 2018
Merged

Remove logical.Initialize() method #3848

merged 3 commits into from
Jan 26, 2018

Conversation

vishalnayak
Copy link
Contributor

No description provided.

@vishalnayak vishalnayak added this to the 0.9.2 milestone Jan 25, 2018
@briankassouf
Copy link
Contributor

Looks good! I think you can also pull out the framework.Backend's Init variable!

@briankassouf
Copy link
Contributor

This one: https://github.com/hashicorp/vault/blob/master/logical/framework/backend.go#L76

@calvn
Copy link
Contributor

calvn commented Jan 25, 2018

In the same spirit, IniatilizeFunc can be also removed right?

@vishalnayak
Copy link
Contributor Author

vishalnayak commented Jan 25, 2018 •
edited
Loading

@briankassouf @calvn Addressed both of your comments and some more fix ups in tests.

@jefferai
Copy link
Member

Glorious

briankassouf
briankassouf previously approved these changes Jan 26, 2018
View reviewed changes
Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jefferai
Copy link
Member

Dooooo ittttttt

@vishalnayak vishalnayak merged commit 909b9ff into master Jan 26, 2018
@vishalnayak vishalnayak deleted the rm-initialize branch January 26, 2018 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf left review comments

@jefferai jefferai Awaiting requested review from jefferai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.2
Development

Successfully merging this pull request may close these issues.
4 participants
@vishalnayak @briankassouf @calvn @jefferai