Don't allow non-printable characters in the API client's token #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A better place to do this would be SetToken but that would require API breaks so this is a better solution for now.
api/client_test.go
Outdated
| @@ -95,6 +96,23 @@ func TestClientToken(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestClientBadToken(t *testing.T) { | |||
| tokenValue := "foo\u007f" | |||
There was a problem hiding this comment.
Can we also test a token that should pass the printable check?
briankassouf
previously approved these changes
Jan 24, 2018
calvn
previously approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better place to do this would be SetToken but that would require API
breaks so this is a better solution for now.