Don't call LeaseExtend on login renewal paths when period is provided #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Jan 16, 2018
| if err != nil { | ||
| return nil, err | ||
| // If a period is provided, set that as part of resp.Auth.Period and return a | ||
| // response immediately. Let expiration manager handle renewal from thereon. |
jefferai
reviewed
Jan 16, 2018
vault/expiration_test.go
Outdated
| TTL: 5 * time.Second, | ||
| Renewable: true, | ||
| }, | ||
| // Period: 5 * time.Second, |
There was a problem hiding this comment.
I'm confused what this test is supposed to be doing -- it has period in the name but this is commented out.
jefferai
reviewed
Jan 16, 2018
vault/expiration_test.go
Outdated
|
|
||
| // Wait 3 seconds | ||
| // time.Sleep(3 * time.Second) | ||
| out, err := exp.RenewToken(&logical.Request{}, "auth/foo/login", root.ID, 0) |
There was a problem hiding this comment.
What is this supposed to be doing?
jefferai
reviewed
Jan 16, 2018
vault/expiration_test.go
Outdated
| fmt.Println(out.Auth) | ||
|
|
||
| // time.Sleep(3 * time.Second) | ||
| out, err = exp.RenewToken(&logical.Request{}, "auth/foo/login", root.ID, 0) |
There was a problem hiding this comment.
Same here. There's no sleep, I'm not sure what having this twice in a row is supposed to be doing.
jefferai
reviewed
Jan 16, 2018
vault/expiration_test.go
Outdated
| t.Fatalf("err: %v", err) | ||
| } | ||
|
|
||
| fmt.Println(out.Auth) |
There was a problem hiding this comment.
Normally we don't print out values on success
jefferai
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.