Add json.Number parsing for iam_request_header values #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified by reporter. |
| case []interface{}: | ||
| for _, individualVal := range typedValue { | ||
| switch possibleStrVal := individualVal.(type) { | ||
| case string: | ||
| headers.Add(k, possibleStrVal) | ||
| case json.Number: | ||
| headers.Add(k, possibleStrVal.String()) | ||
| default: | ||
| return nil, fmt.Errorf("header %q contains value %q that has type %s, not string", k, individualVal, reflect.TypeOf(individualVal)) |
There was a problem hiding this comment.
This error message and the one a few lines below are now incorrect since it also accepts json.Number.
There was a problem hiding this comment.
@joelthompson I actually thought about that and was about 60% leaving it this way and 40% changing it. The reason is twofold: one, technically json.Number is a special casing of a string inside Go with some extra parsing logic; the other is that headers are supposed to always be strings, so we are now accepting ints for content-length but it's still incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3763