Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure revocation happens before seal/step-down #3500

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Ensure revocation happens before seal/step-down #3500

merged 1 commit into from
Nov 2, 2017

Conversation

jefferai
Copy link
Member

Since token store isn't available after when using single-use tokens

Fixes #3497

@jefferai
Ensure revocation happens before seal/step-down since token store isn't
25ec3a0 
available after when using single-use tokens.

Fixes #3497
@jefferai jefferai added this to the 0.8.4 milestone Oct 27, 2017
@jefferai jefferai requested review from calvn and vishalnayak October 27, 2017 17:57
vishalnayak
vishalnayak approved these changes Nov 2, 2017
View reviewed changes
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jefferai jefferai merged commit 66b2d26 into master Nov 2, 2017
@jefferai jefferai deleted the issue-3497 branch November 2, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnayak vishalnayak vishalnayak approved these changes

@calvn calvn Awaiting requested review from calvn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jefferai @vishalnayak