Change behavior of TTL in sign-intermediate #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows signing CA certs with an expiration past the signer's NotAfter. It also change sign-self-issued to replace the Issuer, since it's potentially RFC legal but stacks won't validate it. Ref: https://groups.google.com/d/msg/vault-tool/giP69-n2o20/FfhRpW1vAQAJ
chrishoffman
approved these changes
Sep 13, 2017
chrishoffman
pushed a commit
that referenced
this pull request
Sep 14, 2017
* oss/master: changelog++ update enterprise urls /docs/vault-enterprise -> /docs/enterprise (#3333) Fixed docs to reflect correct HTTP method for /sys/config/auditing endpoing (#3331) changelog++ Change behavior of TTL in sign-intermediate (#3325) changelog++ Sanitize policy behavior across backends (#3324) Fix typo in transit error remove token header from login samples (#3320) Fix navigation and prameters in the 'gcp' auth backend docs. (#3317) changelog++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows signing CA certs with an expiration past the signer's NotAfter.
It also change sign-self-issued to replace the Issuer, since it's potentially RFC legal but stacks won't validate it, and fixes an error with which key is encoded into the resulting cert.
Ref: https://groups.google.com/d/msg/vault-tool/giP69-n2o20/FfhRpW1vAQAJ