Adding latency injector option to -dev mode for storage operations #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Sep 5, 2017
| ) | ||
|
|
||
| // LatencyInjector is used to add latency into underlying physical requests | ||
| type LatencyInjector struct { |
There was a problem hiding this comment.
Since this and (TransactionalLatencyInjector) is really an implementation of the Physical interface, should we call this LatencyBackend to keep things uniform with other physical backend implementations?
There was a problem hiding this comment.
It is not a backend itself and just wraps some other backend that is why I didn't call it a backend. It is more analogous to the Cache wrapper.
jefferai
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a general latency injector that can be enabled in dev mode to simulate storage latency while still using the in-memory backend.