fix swallowed errors in pki package tests #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this PR need anything to move forward, @jefferai? |
|
No, just time for me to get through my backlog and have this float back up. |
|
Also, quite curious how you're finding these and/or why. I have no real issue merging them even though in many cases the lack of error checking is purposeful (as in, we know that a test will panic if an error is returned, which is also automatically a failure, but there's no real issue being explicit), just wondering if it's out of interest on your end or if it's something like running static analysis tools over the codebase. |
|
Yes, I'm using staticcheck to lint the codebase. I posted about what I'm up
to on the email list this morning.
|
chrishoffman
pushed a commit
that referenced
this pull request
Aug 30, 2017
* oss/master: changelog++ add support to use application default credentials to gcs storage backend (#3257) Remove fake news about custom plugins Fix travis build on go 1.9 changelog++ stdout support for file backend via logger (#3235) fix swallowed errors in pki package tests (#3215) Fix API/AUTH/AppRole doc issue concerning bound_cidr_list (#3205)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two swallowed errors were recently introduced in the tests for the pki package.