Improve sts header parsing #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Jul 17, 2017
builtin/credential/aws/path_login.go
Outdated
| @@ -1407,7 +1406,38 @@ func parseGetCallerIdentityResponse(response string) (GetCallerIdentityResponse, | |||
| return result, err | |||
| } | |||
|
|
|||
| func submitCallerIdentityRequest(method, endpoint string, parsedUrl *url.URL, body string, headers http.Header) (*GetCallerIdentityResult, error) { | |||
| func parseIamRequestHeaders(headersB64 string) (*http.Header, error) { | |||
There was a problem hiding this comment.
http.Header is a typedef for map[string][]string and as such it's a reference type -- return it directly, not as a pointer.
jefferai
reviewed
Jul 17, 2017
builtin/credential/aws/path_login.go
Outdated
| } | ||
| } | ||
| default: | ||
| return nil, fmt.Errorf("Header %q value %q has type %s, not string or []interface", k, typedValue, reflect.TypeOf(v)) |
jefferai
requested changes
Jul 17, 2017
This refactors the parsing of iam_request_headers parameter into a separate method to make it easy to add unit tests around the parsing, in preparation for relaxing the header requirements (issue 2810).
This allows headers to be of both map[string][]string (which is http.Header -- the existing format) and map[string]string to be more interoperable with other languages and SDKs.
joelthompson
force-pushed
the
improve_sts_header_parsing
branch
from
f7c1389 to
03fdfb2
Compare
|
Done.
No, thank you, I learned something new about go so it's great! :) |
jefferai
approved these changes
Jul 18, 2017
|
Looks good -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the best way to do so in go, so please let me know if there's a better way of accomplishing this!
Fixes #2810