Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to current fragments, standbyfragments and partialMonthTracker #29066

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

divyaac
Copy link
Contributor

@divyaac divyaac commented Dec 2, 2024

Description

Link to ENT PR: https://github.com/hashicorp/vault-enterprise/pull/7040

What does this PR do?
Jira: https://hashicorp.atlassian.net/browse/VAULT-32420

Removes fragment, standbyFragmentsReceived, partialMonthClientTracker
fragmentLock is still maintained to protect enable
currentSegment is replaced with currentGlobalSegment and currentLocalSegment
updated some tests in vault/logical_system_activity_write_testonly_test.go to test local and global storage paths

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@divyaac divyaac requested review from a team as code owners December 2, 2024 03:15
@divyaac divyaac requested review from MooCohen and removed request for a team December 2, 2024 03:16
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 2, 2024
@divyaac divyaac requested review from VioletHynes and removed request for a team and MooCohen December 2, 2024 03:16
@divyaac divyaac added this to the 1.19.0-rc milestone Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Dec 2, 2024

Build Results:
All builds succeeded! ✅

VioletHynes
VioletHynes previously approved these changes Dec 2, 2024
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks :)

@divyaac divyaac requested review from a team, victorr and stevendpclark and removed request for a team and victorr December 2, 2024 18:19
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PKI acme test change makes sense to me.

@divyaac divyaac merged commit 6ed4ad0 into main Dec 2, 2024
92 checks passed
@divyaac divyaac deleted the vault-32420 branch December 2, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants