PKI: Add a new leaf_not_after_behavior value to force erroring in all circumstances #28907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… circumstances - We introduce a new value called `always_enforce_err` for the existing leaf_not_after_behavior on a PKI issuer. The new value will force we error out all requests that have a TTL beyond the issuer's NotAfter value. - This will apply to leaf certificates issued through the API as did err, but now to CA issuance and ACME requests for which we previously changed the err configuration to truncate.
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
sgmiller
approved these changes
Nov 15, 2024
| @@ -710,6 +710,85 @@ func TestAcmeConfigChecksPublicAcmeEnv(t *testing.T) { | |||
| require.NoError(t, err) | |||
| } | |||
|
|
|||
| // TestAcmeHonorsAlwaysEnforceErr verifies that we get an error and not truncated if the issuer's | |||
| // leaf_not_after_behavior is set to always_enforce_err | |||
| func TestAcmeHonorsAlwaysEnforceErr(t *testing.T) { | |||
There was a problem hiding this comment.
Nice thoroughness with this test.
kitography
approved these changes
Nov 15, 2024
stevendpclark
deleted the
stevendpclark/vault-32446-add-new-leaf-not-after-behavior
branch
|
Thanks all! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We introduce a new value called
always_enforce_errfor the existing leaf_not_after_behavior on a PKI issuer. The new value will force we error out all requests that have a TTL beyond the issuer's NotAfter value.This will apply to leaf certificates issued through the API as did err, but now to CA issuance and ACME requests for which we previously changed the err configuration to truncate.
UI Updates
Added a simple option with text drop down, I only saw the field saw on the PKI edit configuration screen. The new value is the one above the selected value in the screenshot.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.