-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAULT-31594 Add debug level logging to the LDAP auth library #28881
Conversation
CI Results: |
Build Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
One comment that is not blocking: I think the IsDebug checks are unnecessary. No need to remove them now. But in the future we probably only need to do this when we are calculating a value in a hot path for requests.
I added the |
@JMGoldsmith I don't see the 1.17 backport PR. Was there an error in the backport workflow? |
Possibly, will check. |
Description
What does this PR do?
This PR updates the LDAP authentication to use debug level logging. After the introduction of the CAP library the debug logging was removed. This PR adds it back.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+ent
labels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.x
label, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.