Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-31594 Add debug level logging to the LDAP auth library #28881

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

JMGoldsmith
Copy link
Collaborator

Description

What does this PR do?

This PR updates the LDAP authentication to use debug level logging. After the introduction of the CAP library the debug logging was removed. This PR adds it back.

TODO only if you're a HashiCorp employee

  • [x ] Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • [ x ] Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@JMGoldsmith JMGoldsmith added pr/no-milestone backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Nov 12, 2024
@JMGoldsmith JMGoldsmith requested a review from a team as a code owner November 12, 2024 10:32
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Nov 12, 2024

Build Results:
All builds succeeded! ✅

@JMGoldsmith JMGoldsmith changed the title VAULT-31594 initial commit of debug error handling VAULT-31594 Add debug level logging to the LDAP auth library Nov 12, 2024
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

One comment that is not blocking: I think the IsDebug checks are unnecessary. No need to remove them now. But in the future we probably only need to do this when we are calculating a value in a hot path for requests.

@fairclothjm
Copy link
Contributor

I added the backport/1.18.x label since that one was missing

@JMGoldsmith JMGoldsmith merged commit 3f62ae7 into main Nov 18, 2024
96 checks passed
@JMGoldsmith JMGoldsmith deleted the auth/ldap-debug-fix branch November 18, 2024 11:49
@fairclothjm
Copy link
Contributor

@JMGoldsmith I don't see the 1.17 backport PR. Was there an error in the backport workflow?

@JMGoldsmith
Copy link
Collaborator Author

@JMGoldsmith I don't see the 1.17 backport PR. Was there an error in the backport workflow?

Possibly, will check.

@JMGoldsmith JMGoldsmith added backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent and removed backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants