Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stored seal generation info for response to sys/seal-backend-status #28631

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

victorr
Copy link
Contributor

@victorr victorr commented Oct 8, 2024

Description

Use stored seal generation info for response to sys/seal-backend-status.

This fixes an issue where reading from sys/seal-backend-status can return stale information from non-active nodes.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@victorr victorr added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Oct 8, 2024
@victorr victorr added this to the 1.18.1 milestone Oct 8, 2024
@victorr victorr requested a review from a team October 8, 2024 19:33
@victorr victorr self-assigned this Oct 8, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Build Results:
All builds succeeded! ✅

@victorr victorr force-pushed the victorr/vault-31286-fix-sys-sealbackendstatus branch from 7bcd6a9 to 9d87e6f Compare October 8, 2024 19:36
Copy link

github-actions bot commented Oct 8, 2024

CI Results:
All Go tests succeeded! ✅

@victorr victorr force-pushed the victorr/vault-31286-fix-sys-sealbackendstatus branch from 9d87e6f to 805881f Compare October 8, 2024 20:06
@victorr victorr enabled auto-merge (squash) October 8, 2024 20:07
@victorr victorr force-pushed the victorr/vault-31286-fix-sys-sealbackendstatus branch from 805881f to f3846eb Compare October 9, 2024 13:06
@victorr victorr disabled auto-merge October 9, 2024 13:46
@victorr victorr enabled auto-merge (squash) October 9, 2024 13:53
@victorr victorr merged commit 770d902 into main Oct 9, 2024
90 checks passed
@victorr victorr deleted the victorr/vault-31286-fix-sys-sealbackendstatus branch October 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants