Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-30219 CE changes for versioned secret fix #28207

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

VioletHynes
Copy link
Contributor

@VioletHynes VioletHynes commented Aug 28, 2024

Description

CE counterpart for https://github.com/hashicorp/vault-enterprise/pull/6544

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 28, 2024
@VioletHynes VioletHynes added this to the 1.18.0-rc milestone Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

CI Results:
All Go tests succeeded! ✅

@VioletHynes VioletHynes marked this pull request as ready for review August 28, 2024 13:56
Copy link

Build Results:
All builds succeeded! ✅

@VioletHynes VioletHynes merged commit a5262e0 into main Aug 28, 2024
96 of 107 checks passed
@VioletHynes VioletHynes deleted the violethynes/VAULT-30219-ce branch August 28, 2024 15:29
hellobontempo pushed a commit that referenced this pull request Aug 28, 2024
* VAULT-30219 CE changes for versioned secret fix

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants