Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSS stub functions for Self-Managed Static Roles #28199

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Aug 27, 2024

Description

This PR adds the Self-Managed Static Role workflow fields and mechanism, along with OSS Stub functions to ensure this feature is Enterprise-Only. These fields will exist in this repo but full functionaility is only available in Vault Ent. Please see the Vault Ent PR for further reference.

Link to ADR for feature.

Enterprise PR link: https://github.com/hashicorp/vault-enterprise/pull/6261

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 27, 2024
@vinay-gopalan vinay-gopalan added this to the 1.18.0-rc milestone Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Aug 27, 2024

Build Results:
All builds succeeded! ✅

@vinay-gopalan vinay-gopalan requested a review from a team August 27, 2024 17:12
@vinay-gopalan vinay-gopalan enabled auto-merge (squash) August 28, 2024 17:46
@vinay-gopalan vinay-gopalan requested a review from a team as a code owner August 28, 2024 22:00
@vinay-gopalan vinay-gopalan removed the request for review from a team August 28, 2024 22:02
@vinay-gopalan vinay-gopalan changed the title Add OSS stub function for retrieving Static Connections Add OSS stub functions for retrieving Static Connections Aug 29, 2024
@vinay-gopalan vinay-gopalan changed the title Add OSS stub functions for retrieving Static Connections Add OSS stub functions for Self-Managed Static Roles Aug 29, 2024
@thyton thyton self-requested a review August 29, 2024 16:57
Copy link
Contributor

@thyton thyton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stubs addition and TestUpdateUser_SelfManaged_OSS() look great!

Copy link
Contributor

@Zlaticanin Zlaticanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinay-gopalan vinay-gopalan merged commit ec9b675 into main Aug 29, 2024
83 checks passed
@vinay-gopalan vinay-gopalan deleted the VAULT-27992/smsr-oss-stub branch August 29, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants