Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if storage should be updated during invalidation #28059

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

elliesterner
Copy link
Contributor

@elliesterner elliesterner commented Aug 13, 2024

Description

The move command vault secrets move kv1 kv2 and vault auth move userpass1 userpass2 calls the sys/remount endpoint, which always gets forwarded to the active node. If performance standbys are present in the cluster, they will attempt to write to storage during invalidation. This PR makes sure that perf standbys don't write to storage, to avoid the logical.ErrReadOnly error.

ENT PR
JIRA

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 13, 2024
@elliesterner elliesterner added backport/1.17.x backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Aug 13, 2024

Build Results:
All builds succeeded! ✅

@elliesterner elliesterner changed the title check if storage should be updated during invalidation Check if storage should be updated during invalidation Aug 13, 2024
@elliesterner elliesterner added this to the 1.18.0-rc milestone Aug 13, 2024
@biazmoreira
Copy link
Contributor

Would you like me to wait until the tests are fixed to review it?

@elliesterner
Copy link
Contributor Author

Would you like me to wait until the tests are fixed to review it?

My bad! These tests should be in ENT only. I'll pull them out.

Copy link
Contributor

@mpalmi mpalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@davidadeleon davidadeleon merged commit 6558df4 into main Aug 22, 2024
83 checks passed
@davidadeleon davidadeleon deleted the elliesterner/check-storage-on-move branch August 22, 2024 21:00
davidadeleon added a commit that referenced this pull request Aug 23, 2024
* check if storage should be updated during invalidation

* add changelog

* add other tests and fix for auth move

* fix changelog

* fix comment

* remove ent tests

---------

Co-authored-by: davidadeleon <[email protected]>
davidadeleon added a commit that referenced this pull request Aug 23, 2024
* check if storage should be updated during invalidation

* add changelog

* add other tests and fix for auth move

* fix changelog

* fix comment

* remove ent tests

---------

Co-authored-by: Ellie <[email protected]>
Co-authored-by: davidadeleon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants