Fixes #2789 #2790
Merged
Fixes #2789 #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects DynamoDB record path resolution when running Vault server on Windows
|
@ebekker nice catch! I think the |
|
Ah yes, much nicer, the global replace of |
Applying wholesale switch from `filepath` to `path` package for record path manipulation, which ignores OS-specific file separators
|
@seiffert -- since you are the original author of this backend, wondering if you can do a quick sanity check to make sure that I didn't miss some nuance of your original implementation by doing a switch from |
|
This change makes sense to me. Thanks! |
jefferai
approved these changes
Jun 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects DynamoDB record path resolution when running Vault server on
Windows