Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Fix ACME Account Safety Buffer not able to be turned off into release/1.17.x #27751

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #27742 to be assessed for backporting due to the inclusion of the label backport/1.17.x.

The below text is copied from the body of the original PR.


Description

This PR fixes a bug where turning on "ACME Account Safety Buffer" in PKI Tidy and then turning it off would not allow to save due to sending the value for acme_account_safety_buffer as 0s. To resolve, I set the default value for this setting to 720h which is the equivalent of 30 days -- the default according to the docs.

Error on save
image

Success with changes
Kapture 2024-07-10 at 10 07 22


Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 10, 2024
@hashishaw hashishaw added this to the 1.17.3 milestone Jul 10, 2024
@hashishaw hashishaw added the ui label Jul 10, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw merged commit 7245708 into release/1.17.x Jul 10, 2024
27 of 28 checks passed
@hashishaw hashishaw deleted the backport/ui/VAULT-27854/acme-account-safety-buffer-off/heavily-first-toad branch July 10, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants