Return the proper serial number in OCSP verification errors #27696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We returned the issuer's certificate number instead of the serial number of the actual certificate we validated from an OCSP request. - The problematic serial number within the error are never shown currently in Vault. The only user of this library is cert-auth which swallows errors around revoked certificates and returns a boolean false instead of the actual error message.
stevendpclark
added
backport/ent/1.15.x+ent
backport/ent/1.16.x+ent
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
stevendpclark
force-pushed
the
stevendpclark/fix-ocsp-error-msg
branch
from
49d32cc to
d714a98
Compare
sgmiller
approved these changes
Jul 5, 2024
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #27126
VAULT-28667
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.