Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-28255: Fix namespaced redirects #27660

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

miagilepner
Copy link
Contributor

Description

Fix redirects when a namespace is included in the namespace header, or for events when it's included in the path.
Fixes #27551.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@miagilepner miagilepner added backport/ent/1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Jul 2, 2024
@miagilepner miagilepner added this to the 1.18.0-rc milestone Jul 2, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jul 2, 2024

Build Results:
All builds succeeded! ✅

@miagilepner miagilepner merged commit 9e299c2 into main Jul 3, 2024
77 of 78 checks passed
@miagilepner miagilepner deleted the miagilepner/events-namespace-forwarding branch July 3, 2024 08:08
miagilepner added a commit that referenced this pull request Jul 3, 2024
* handle namespaced events redirects

* full test:

* changelog

* lint
@miagilepner miagilepner added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent and removed backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Jul 3, 2024
miagilepner added a commit that referenced this pull request Jul 3, 2024
* handle namespaced events redirects

* full test:

* changelog

* lint

Co-authored-by: miagilepner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe to events notifications does not work on secondary nodes
3 participants