Add max_parallel parameter to MySQL backend. #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason not to do this with the permit pool and |
This limits the number of concurrent connections, so that vault does not die suddenly from "Too many connections". This can happen when e.g. vault starts up, and tries to load all the existing leases in parallel. At the time of writing this, the value ExpirationRestoreWorkerCount in vault/helper/consts/const.go is set to 64, meaning that if there are enough leases in the vault's DB, it will generate AT LEAST 64 concurrent connections to MySQL when loading the data during start-up. On certain configurations, e.g. smaller AWS RDS/Aurora instances, this will cause Vault to fail startup.
ikatson
force-pushed
the
mysql-backend-max-connections
branch
from
d533acd to
b5c2456
Compare
|
@jefferai sure, didn't know about its existence. Reimplemented now with PermitTool and rebased. Although it seems a little bit slower, probably the lock is coarser than internal db/mysql one. |
|
That CI error does not seem related, seems like smth else in master is broken |
ikatson
changed the title
jefferai
reviewed
May 25, 2017
| @@ -42,6 +42,9 @@ storage "mysql" { | |||
| - `tls_ca_file` `(string: "")` – Specifies the path to the CA certificate to | |||
| connect using TLS. | |||
|
|
|||
| - `max_parallel` `(string: "128")` – Specifies The maximum number of concurrent | |||
jefferai
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits the number of concurrent connections, so that vault does not die suddenly from "Too many connections".
This can happen when e.g. vault starts up, and tries to load all the existing leases in parallel. At the time of writing this, the value ExpirationRestoreWorkerCount is set to 64, meaning that if there are enough leases in the vault's DB, it will generate AT LEAST 64 concurrent connections to MySQL when loading the data during start-up. On certain configurations, e.g. smaller AWS RDS/Aurora instances, this will cause Vault to fail startup.