Audit: check if context is already cancelled when assessing viability for audit #27531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the audit system is asked to log a request or response, it now checks the viability of the existing supplied context. The context is considered unviable if it has
<5s
remaining on its deadline, and a new context is created for use.However, we're seeing issues where some users are getting audit log failures as the incoming context is already cancelled entirely. This means that audit will fail and report telemetry etc. which isn't what users want.
This PR includes the cancelled context in its evaluation of viability, and will create a new context with a
5s
timeout if it is cancelled.NOTE: We don't just return immediately from
LogRequest
andLogResponse
if the context was cancelled, as we want to make every effort to capture that Vault was asked to service a request - in the audit log.Should resolve: #27521