Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIGUSR2 pprof to agent and proxy #27510

Merged
merged 10 commits into from
Jun 17, 2024
Merged

Add SIGUSR2 pprof to agent and proxy #27510

merged 10 commits into from
Jun 17, 2024

Conversation

jasonodonnell
Copy link
Contributor

@jasonodonnell jasonodonnell commented Jun 15, 2024 •
edited
Loading

This adds the ability to get pprof data from Agent and Proxy using SIGUSR2, similar to Vault server.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 15, 2024
@jasonodonnell jasonodonnell added this to the 1.17.1 milestone Jun 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 15, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 15, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

VioletHynes
VioletHynes approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! We should add this to Proxy too -- if it's not too much to ask :)

command/agent.go Outdated Show resolved Hide resolved
command/agent.go Outdated Show resolved Hide resolved
@jasonodonnell
Copy link
Contributor Author

This looks good! We should add this to Proxy too -- if it's not too much to ask :)

Added!

@jasonodonnell jasonodonnell changed the title Add SIGUSR2 pprof to agent Add SIGUSR2 pprof to agent and proxy Jun 17, 2024
VioletHynes
VioletHynes reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Two small suggestions (changelog for proxy, and update to vault-proxy-pprof) but this looks great. Thanks for adding this!

command/proxy.go Outdated Show resolved Hide resolved
changelog/27510.txt Show resolved Hide resolved
VioletHynes
VioletHynes approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for refactoring this to be even cleaner :)

@jasonodonnell jasonodonnell enabled auto-merge (squash) June 17, 2024 15:16
@jasonodonnell jasonodonnell merged commit fe1f36a into main Jun 17, 2024
83 checks passed
@jasonodonnell jasonodonnell deleted the pprof-agent branch June 17, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VioletHynes VioletHynes VioletHynes approved these changes

@divyaac divyaac Awaiting requested review from divyaac

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.17.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonodonnell @VioletHynes