Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump etcd client to v3.5.13 #26660

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

tsaarni
Copy link
Contributor

@tsaarni tsaarni commented Apr 26, 2024

This change updates to latest etcd client version. It allows TLSv1.3 to be used between Vault and etcd.

Fixes #26659

@heatherezell heatherezell added storage/etcd dependencies Pull requests that update a dependency file labels May 7, 2024
@tsaarni tsaarni force-pushed the etcd-client-bump branch from 4907135 to 97b9e23 Compare May 16, 2024 13:47
@tsaarni
Copy link
Contributor Author

tsaarni commented May 16, 2024

@hsimon-hashicorp @stevendpclark 👋 Just a gentle nudge 😄

I just wanted to follow up on this PR and check if you had a chance to consider its inclusion, as it would fix a TLS 1.3 issue for users.

Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for this. I don't see any issues with including this, so I'll try and get this merged :)

@VioletHynes
Copy link
Contributor

@tsaarni it looks like there are merge conflicts with main -- sorry for jumping the gun with my last comment. If you could get them fixed and tag me when it's ready to merge again, I can hit the merge button if everything looks good.

Sorry this one took a little bit to get some eyes on :)

Signed-off-by: Tero Saarni <[email protected]>
@tsaarni tsaarni force-pushed the etcd-client-bump branch from 97b9e23 to adb9b05 Compare May 27, 2024 18:15
@tsaarni
Copy link
Contributor Author

tsaarni commented May 27, 2024

Thank You @VioletHynes for the review! Now again ready for merge :)

@VioletHynes VioletHynes merged commit 4975e69 into hashicorp:main May 27, 2024
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file storage/etcd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLSv1.3 does not work with etcd storage backend
3 participants