Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for ACME clients in precomputed queries #26519

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Add metrics for ACME clients in precomputed queries #26519

merged 2 commits into from
Apr 26, 2024

Conversation

raskchanky
Copy link
Contributor

@raskchanky raskchanky added this to the 1.17.0-rc milestone Apr 18, 2024
@raskchanky raskchanky requested a review from miagilepner April 18, 2024 18:36
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 18, 2024
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

miagilepner
miagilepner approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raskchanky raskchanky merged commit ceb8691 into main Apr 26, 2024
83 checks passed
@raskchanky raskchanky deleted the add-acme-metrics-to-precomputed-queries branch April 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miagilepner miagilepner miagilepner approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.17.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@raskchanky @miagilepner