Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not lowercase groups attached to users in ldap #2613

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Do not lowercase groups attached to users in ldap #2613

merged 1 commit into from
Apr 19, 2017

Conversation

chrishoffman
Copy link
Contributor

Fixes #2612

@jefferai
Copy link
Member

I feel like we should sed ParseDedupAndSortStrings to ParseDedupLowercaseAndSortStrings. This keeps biting us, even worse as a regression.

@chrishoffman
Copy link
Contributor Author

rename PR in :) #2614

@chrishoffman chrishoffman merged commit c4cc3fd into master Apr 19, 2017
@chrishoffman chrishoffman deleted the dont-lowercase-ldap-groups branch April 19, 2017 14:36
@chrishoffman chrishoffman mentioned this pull request Apr 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnayak vishalnayak vishalnayak approved these changes

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrishoffman @jefferai @vishalnayak