Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the configured address's path in the client #2588

Merged
merged 4 commits into from
Apr 13, 2017
Merged

Respect the configured address's path in the client #2588

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e232743
Respect the configured address's path in the client
Apr 12, 2017
8f84755
use tabs
Apr 12, 2017
b07dbf6
Use path.Join
Apr 12, 2017
75d45c4
Fix parameter name
Apr 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ func (c *Client) NewRequest(method, path string) *Request {
User: c.addr.User,
Scheme: c.addr.Scheme,
Host: c.addr.Host,
Path: path,
Path: strings.TrimSuffix(c.addr.Path, "/") + path,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use path.Join() instead of trimming the "/"?

},
ClientToken: c.token,
Params: make(map[string][]string),
Expand Down