Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Only add user lockout config for supported methods #25867

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Mar 11, 2024

When I added these params in #25646 - I missed that they're only supported by approle, ldap, and userpass - this PR fixes that!

enterprise tests ✅
Screenshot 2024-03-11 at 11 00 53 AM

@hellobontempo hellobontempo added this to the 1.16.0 milestone Mar 11, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo marked this pull request as ready for review March 11, 2024 14:55
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, thank you!

@hellobontempo hellobontempo merged commit d989eae into main Mar 11, 2024
34 checks passed
@hellobontempo hellobontempo deleted the ui/VAULT-24800/hide-user-lockout-config-for-unsupported-methods branch March 11, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants