Backport of Only disable quotas on the primary cluster into release/1.14.x #25701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
raskchanky
approved these changes
Feb 28, 2024
|
Build Results: |
|
CI Results: |
raskchanky
deleted the
backport/fix-namespace-quota-deletion/hardly-proper-bat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #25439 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
https://hashicorp.atlassian.net/browse/VAULT-22381
tl;dr - setting up a rate limit quota inside a namespace and then deleting the namespace when perf replication is enabled causes the PR secondary to error when doing sync invalidation on the mount table and stop replication because it's trying to delete the quota from the PR secondary storage, which of course is read-only for quotas.
Making this change kept replication up and running and I verified that after the namespace was deleted on the primary, the associated rate limit was also gone from the secondary.
Although this change is to a CE file, it seems worth maybe opening this PR on ENT as well, just to let CI run?
Overview of commits