Audit: Extracted SSCT related auditing code to formatter node #25443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… broker, moved SSCT overwrite to entry formatter
peteski22
added
bug
VioletHynes
approved these changes
Feb 15, 2024
|
CI Results: |
|
Build Results: |
I did run it, but alas I cannot get it to fail locally with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a potential race condition which occurred when an SSCT is present in the auth related audit entry.
It removes some unrequired code which captured the current headers, and moves the logic for updating the client token with the SSCT to the entry formatter which deals with a cloned version of the input.
Previous race detection occurred in
command/agentproxyshared/auth TestAuthHandler