identity: adds generation of plugin identity tokens #25219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
tomhjp
approved these changes
Feb 6, 2024
Co-authored-by: Tom Proctor <[email protected]>
fairclothjm
approved these changes
Feb 6, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Feb 7, 2024
* adds generation of plugin identity tokens * adds constants * fix namespace path when getting matching identity storage * adds changelog * adds godoc on test * fix data race with default key generation by moving locks up * Update changelog/25219.txt Co-authored-by: Tom Proctor <[email protected]> * use namespace from context instead of mount entry * translate mount table entry from mounts to secret * godoc on test --------- Co-authored-by: Tom Proctor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces generation of plugin identity tokens to the identity store. This allows plugins to consume them over the
GenerateIdentityToken()method of the system view.Other important aspects of this PR:
I've added a test that generates JWTs, verifies their signatures, and validates a majority of claims. A test that integrates with a plugin consuming these tokens (AWS secret engine) will be added in a follow-up PR.