UI: k8s auth openapi update #25218
Merged
UI: k8s auth openapi update #25218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
| @@ -605,6 +605,14 @@ const kubernetes = { | |||
| label: 'Token Reviewer JWT', | |||
| type: 'string', | |||
| }, | |||
| useAnnotationsAsAliasMetadata: { | |||
| editType: 'boolean', | |||
| fieldGroup: 'default', | |||
There was a problem hiding this comment.
It looks like the fieldGroup above is Kubernetes Options. I can't remember how this openAPI test is setup, does this need to match above?
There was a problem hiding this comment.
Good catch -- the fieldGroup is coming from the OpenAPI response, so if it's default from there maybe that means the checkmark needs to be in the main fields instead. I'll check with eco
There was a problem hiding this comment.
Confirmed that the option should be in this section -- the kubernetes plugin authors probably don't know that the fieldgroup value is for organizing the options in the form
There was a problem hiding this comment.
Thanks for confirming and following up!
hellobontempo
approved these changes
Feb 5, 2024
|
Build Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Kubernetes config param,
use_annotations_as_alias_metadata. This was caught via one of the OpenAPI tests.The new param was added in this PR and Vault is updated to consume the new version in this PR
Config form has param:
