sdk: add identity token helpers to consistently apply fields in plugins #24925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
vinay-gopalan
commented
Jan 17, 2024
vinay-gopalan
commented
Jan 17, 2024
|
|
||
| for name, schema := range fields { | ||
| if _, ok := m[name]; ok { | ||
| panic(fmt.Sprintf("adding field %q would overwrite existing field", name)) |
There was a problem hiding this comment.
panicking here is consistent with other schema helpers in Vault and other repos (TFVP), can consider returning an error if there are any reasons to do so
|
CI Results: |
|
Build Results: |
austingebauer
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds helper methods to the Vault SDK that allow us to consistently apply the new fields needed for plugin WIF across integrations.