Non-recursive DFS token tree revoke #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
suggested changes
Apr 27, 2017
vault/token_store.go
Outdated
| children, err := ts.view.List(path) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to scan for children: %v", err) | ||
| } |
There was a problem hiding this comment.
Could you run go fmt on your code? https://golang.org/cmd/gofmt/
vault/token_store.go
Outdated
| dfs = dfs[1:l] | ||
| } | ||
| } else { | ||
| // If we make it here, the there are children and they must |
There was a problem hiding this comment.
typo on "the there"
vault/token_store.go
Outdated
| @@ -1120,7 +1131,7 @@ func (ts *TokenStore) handleTidy(req *logical.Request, data *framework.FieldData | |||
| // Scan through the secondary index entries; if there is an entry | |||
| // with the token's salt ID at the end, remove it | |||
| for _, parent := range parentList { | |||
| children, err := ts.view.List(parentPrefix + parent + "/") | |||
There was a problem hiding this comment.
How come this changed?
chrishoffman
approved these changes
May 15, 2017
|
LGTM! |
|
sweet! thanks for all the help! |
|
I'll try to get to a review soon but adding to 0.7.3. |
|
sounds great! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2348