Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Obscure values for nested KV v2 secret #24530

Merged
merged 9 commits into from
Dec 14, 2023

Conversation

hashishaw
Copy link
Contributor

Currently, when a KV v2 secret value has nested objects, the details view shows the JSON without the option to toggle it off. With this PR, the details view will obscure the values for the details view when the secret value has nested objects.

With change

Screenshot 2023-12-13 at 4 39 18 PM

Values are accessible by toggling "Reveal values"
Screenshot 2023-12-13 at 4 39 22 PM

Does not change behavior for simple secrets:
Screenshot 2023-12-13 at 4 40 54 PM

Before:

Screenshot 2023-12-13 at 4 35 11 PM

@hashishaw hashishaw added the ui label Dec 13, 2023
@hashishaw hashishaw added this to the 1.16.0-rc1 milestone Dec 13, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 13, 2023
@hashishaw hashishaw marked this pull request as ready for review December 13, 2023 22:43
Copy link

github-actions bot commented Dec 13, 2023

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! This is a great improvement ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants