UI: HDS adoption update <AlertInline> component to use Hds::Alert #24299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Nov 30, 2023
| @@ -22,8 +22,7 @@ | |||
| /> | |||
| </div> | |||
| <AlertInline | |||
| @sizeSmall={{true}} | |||
There was a problem hiding this comment.
the class size-small no longer exists (functionality have been removed previously?), so remove this arg all together.
hellobontempo
commented
Nov 30, 2023
| @@ -34,5 +34,5 @@ | |||
| /> | |||
| </Hds::SegmentedGroup> | |||
| {{#if this.invalidDate}} | |||
| <AlertInline @type="danger" @message={{this.invalidDate}} @paddingTop={{true}} @mimicRefresh={{true}} /> | |||
There was a problem hiding this comment.
decided to make @mimicRefresh part of the default functionality in this component, since moving forward Hds::Alert should just be used directly if the refresh functionality is not needed
hellobontempo
commented
Nov 30, 2023
hellobontempo
commented
Nov 30, 2023
Comment on lines
56
to
60
| <Icon class="is-flex-v-centered has-text-highlight" @name="alert-triangle-fill" /> | ||
| <Hds::Alert class="is-flex-v-centered" @type="compact" @color="warning" /> | ||
| {{/if}} | ||
| </div> | ||
| {{/each}} | ||
| {{#if this.indicesWithComma}} |
There was a problem hiding this comment.
before
after
Updated to match KvObjectEditor which uses @type="inline"
|
Build Results: |
hellobontempo
commented
Nov 30, 2023
hellobontempo
commented
Nov 30, 2023
| Your data contains an upgrade. | ||
| <DocLink | ||
| @path="/vault/docs/concepts/client-count/faq#q-which-vault-version-reflects-the-most-accurate-client-counts" | ||
| <Hds::Alert class="has-top-padding-m" @type="compact" @color="warning" as |A|> |
Monkeychip
reviewed
Nov 30, 2023
Monkeychip
reviewed
Nov 30, 2023
Monkeychip
approved these changes
Nov 30, 2023
hellobontempo
deleted the
ui/VAULT-17371/hds-adoption-replace-AlertInline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Hds::Alert @type="compact"in theAlertInlinecomponent so styling is consistent throughout UI.