Default to Json editor if KV secret is nested #24290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
Monkeychip
commented
Nov 29, 2023
|
Build Results: |
hashishaw
reviewed
Nov 29, 2023
Monkeychip
added a commit
that referenced
this pull request
Nov 30, 2023
* initial fix * changelog * fix * fix test and add test coverage * remove useless escape characters * pr comments add more test coverage
|
I don't really understand the point of this PR... This is a regression for me. A step backwards in terms of security --> all secrets are now visible, whereas before we could select only the secret we wanted. And now we don't even have the choice of seeing it as we did before. There should be a global option to display JSON by default or not. And not impose the JSON view, which for me is a big step backwards. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a secret that is an object/nested ex:
{ "foo": { "bar": "baz" } }, when you navigate to the details view it should default to a readonly JSON editor and disabled JSON toggle.Making a different ticket for a nice-to-have as it's "new" and should not be backported: show only the keys unless “show values” is toggled on (new toggle)